Deployed Publisher- and Subscription-convenience functions with qos best effort in ping_pong#26
Merged
pablogs9 merged 4 commits intofeature/foxy_migrationfrom Jul 14, 2020
Conversation
Member
|
When the prerequisites are merged I'll try this on the platforms. Thanks @JanStaschulat . |
Contributor
Author
|
Updated the ping_pong example to use rclc_publisher_init_best_effort |
JanStaschulat
changed the title
JanStaschulat
changed the title
JanStaschulat
changed the title
pablogs9
approved these changes
Jul 14, 2020
pablogs9
deleted the
feature/foxy_migration_ping_pong_with_qos_best_effort
branch
pablogs9
added a commit
that referenced
this pull request
Jul 21, 2020
* Update int32_publisher to RCLC (moving required) dep fix * Update int32_subscriber to RCLC (moving required) * Update fragmented publication to RCLC (moving required) * Update guard condition to RCLC timer (moving required) * Update pub/sub to RCLC (moving required) * Updated fragmented subscription to RCLC (moving required) * Updated multinode to RCLC (moving required) * Indentation fix * Fixs * Remove old RCLC examples * Added complex message pub/sub * Updated configured sub/pub * Minor fixes * Minor fix * Update pingpong example with RCLC API * Update timer example * Added string publisher * Renamed RCL folder to RCLC * Indentation fix * Update rclc/complex_msg_publisher/main.c Co-authored-by: Julián Bermúdez Ortega <julianbermudez@eprosima.com> * Update rclc/complex_msg_subscriber/main.c Co-authored-by: Julián Bermúdez Ortega <julianbermudez@eprosima.com> * Indentation fix * Fix * Mantainer * Add complex msgs dep * Deployed Publisher- and Subscription-convenience functions with qos best effort in ping_pong (#26) * use rclc_subscription_init_best_effort * corrected change. * corrected change 2. * use of rclc_publisher_init_best_effort function Co-authored-by: Julián Bermúdez Ortega <julianbermudez@eprosima.com> Co-authored-by: Jan Staschulat <jan.staschulat@de.bosch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
precondition:
PR micro-ROS/rclc#34
PR micro-ROS/rclc#35
use of rclc_subscription_init_best_effort in ping_pong example.
@pablogs9 Please first test the change on your platform before accepting the PR.
I could not test the ping-pong example on my laptop, because I currently don't have a micro-xrcedds setup available.